Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept only string for signing #215

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 9, 2021

  • Accepting bytes (Uint8Array) makes it very complicated because it's not well supported on the interface side via web3.js
  • use ethers hashMessage function that generates eip-191 compliant hash

@mmv08 mmv08 requested a review from germartinez September 9, 2021 09:26
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2021

🦋 Changeset detected

Latest commit: 68b6b7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@gnosis.pm/safe-apps-sdk Patch
@gnosis.pm/safe-apps-provider Patch
@gnosis.pm/safe-apps-react-sdk Patch
@gnosis.pm/safe-apps-web3-react Patch
@gnosis.pm/safe-apps-web3modal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 5 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mmv08 mmv08 merged commit 8777635 into development Sep 9, 2021
@mmv08 mmv08 deleted the feature/signing-only-accept-string branch September 9, 2021 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants