Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for window for SSR #184

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Remove check for window for SSR #184

merged 1 commit into from
Jun 21, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jun 21, 2021

This line will throw if you try to use it with Next.js for example. We want to support SSR, thus we remove this check

This line will throw if you try to use it with Next.js for example. We want to support SSR, thus we remove this check
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2021

⚠️ No Changeset found

Latest commit: 8a48e9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mmv08 mmv08 requested review from germartinez and katspaugh June 21, 2021 07:37
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mmv08 mmv08 merged commit c4d32e2 into development Jun 21, 2021
@mmv08 mmv08 deleted the mikheevm-patch-1 branch June 21, 2021 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants