Feature: Catch exceptions in communicator #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
approved these changes
Jun 9, 2021
| this.callbacks.set(request.id, (response: Response<R>) => { | ||
| if (!response.success) { | ||
| reject(new Error(response.error)); |
There was a problem hiding this comment.
What are some examples of these errors? Maybe we should prefix them with something like "SDK error"?
There was a problem hiding this comment.
If there's a problem processing app's request on the interface side it will send back a message with success: false. One I can think of a 404 from the server for sdk.txs.getTxBySafeTxHash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each method would implement a handler for the error case by itself. This could be moved one layer higher to the communication implementation.
This PR:
remember to run
lerna run buildbefore merging to generate build files