Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe-apps-web3modal refactor, add isSafeApp methods #173

Merged
merged 2 commits into from
May 21, 2021
Merged

safe-apps-web3modal refactor, add isSafeApp methods #173

merged 2 commits into from
May 21, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented May 18, 2021

This PR:

  • a small refactor just to make the codebase more similar to onboard wrapper
  • add isSafeApp method

@mmv08 mmv08 requested review from rmeissner and germartinez May 18, 2021 15:25
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 4 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mmv08 mmv08 merged commit 117bda2 into development May 21, 2021
@mmv08 mmv08 deleted the feature/web3modal-isSafeApp branch May 21, 2021 09:53
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmv08 @germartinez