Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Provider is incompatible with ethers v4 #171

Merged
merged 2 commits into from
May 21, 2021

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented May 17, 2021

This PR:

The problem was that ethers v4 relied on .send and .sendAsync methods that we removed in #140
https://github.com/ethers-io/ethers.js/blob/427e16826eb15d52d25c4f01027f8db22b74b76c/src.ts/providers/web3-provider.ts#L41-L55
I added send method back, it's enough to make it work with ethers v4. Ethers will use .send for .sendAsync too.

@mmv08 mmv08 requested review from rmeissner and germartinez May 17, 2021 10:38
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 12 0
Ignored 2 N/A
  • Result: ✅ success

  • Annotations: 12 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


[warning] @typescript-eslint/no-explicit-any

Disallow usage of the any type


Report generated by eslint-plus-action

@mmv08 mmv08 merged commit 10d19c2 into development May 21, 2021
@mmv08 mmv08 deleted the bug/ethers-v4-incompatible branch May 21, 2021 09:54
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants