Remove test files from build outputs #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks, Tom! One minor thing: could you please do the same thing but in the global ts configuration, so all packages in the monorepo exclude test files? https://github.com/gnosis/safe-apps-sdk/blob/master/tsconfig.json |
|
No worries! Just made the switch to put it in the root config now. |
mmv08
approved these changes
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for the sdk are being included in the build outputs and increasing the size of the package whereas we can safely remove them.