Merge pull request #96 from gnosis/bug/error-not-thrown-if-tx-not-found

Bug: When calling getTxBySafeTxHash every status code is considered success
safe-global · Feb 16, 2021 · 6dad6eb · 6dad6eb
2 parents c8f0366 + 1a727cb
commit 6dad6eb
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/safe-apps-sdk/src/txs/index.ts b/packages/safe-apps-sdk/src/txs/index.ts
@@ -23,6 +23,12 @@ class TXs {
 
     try {
       const res = await fetch(`${this.#txServiceUrl}/transactions/${safeTxHash}`, options);
+      if (res.status !== 200) {
+        throw new Error(
+          "Failed to get the transaction. Either safeTxHash is incorrect or transaction hasn't been indexed by the service yet",
+        );
+      }
+
       const json = await res.json();
 
       return json as TxServiceModel;