Skip to content

Commit

Permalink
Upgrade versions
Browse files Browse the repository at this point in the history
  • Loading branch information
saeub committed Sep 27, 2023
1 parent 540691b commit fa5562b
Show file tree
Hide file tree
Showing 9 changed files with 316 additions and 225 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ jobs:
name: Deploy Android
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@v1
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: '3.3.10'
flutter-version: '3.13.0'
- run: flutter build apk
- uses: w9jds/firebase-action@master
with:
Expand All @@ -23,7 +23,7 @@ jobs:
build/app/outputs/apk/release/app-release.apk \
--app ${{ secrets.FIREBASE_ANDROID_APP_ID }}
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
GCP_SA_KEY: ${{ secrets.FIREBASE_SERVICE_ACCOUNT }}
web:
name: Deploy Web
runs-on: ubuntu-latest
Expand All @@ -32,11 +32,11 @@ jobs:
- uses: subosito/flutter-action@v1
with:
channel: stable
flutter-version: '3.3.10'
flutter-version: '3.13.0'
- run: flutter config --enable-web
- run: flutter build web
- uses: w9jds/firebase-action@master
with:
args: deploy --project ${{ secrets.FIREBASE_PROJECT_ID }}
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
GCP_SA_KEY: ${{ secrets.FIREBASE_SERVICE_ACCOUNT }}
20 changes: 10 additions & 10 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@v1
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: '3.3.10'
- run: flutter format -n --set-exit-if-changed lib/main.dart lib/src/ test/ integration_test/
flutter-version: '3.13.0'
- run: dart format -o none --set-exit-if-changed lib/main.dart lib/src/ test/ integration_test/
- run: flutter analyze
test:
name: Unit tests
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@v1
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: '3.3.10'
flutter-version: '3.13.0'
- run: sudo apt-get update && sudo apt-get install -y lcov
- run: flutter test --coverage
- run: lcov --remove coverage/lcov.info 'lib/generated/*' > coverage/lcov_nogen.info
Expand All @@ -52,11 +52,11 @@ jobs:
- 29
needs: test
steps:
- uses: actions/checkout@v2
- uses: subosito/flutter-action@v1
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
channel: stable
flutter-version: '3.3.10'
flutter-version: '3.13.0'
- uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ matrix.api-level }}
Expand Down
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 32
compileSdkVersion 33

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand Down
6 changes: 3 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
buildscript {
ext.kotlin_version = '1.6.10'
ext.kotlin_version = '1.9.0'
repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:4.1.0'
classpath 'com.android.tools.build:gradle:7.3.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand All @@ -26,6 +26,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ Running tests:

Code formatting / static analysis:

- `flutter format lib/main.dart lib/src/ test/ integration_test/`
- `dart format lib/main.dart lib/src/ test/ integration_test/`
- `flutter analyze`
- Keep translation files (`lib/i10n/*.arb`) sorted
4 changes: 2 additions & 2 deletions lib/src/pages/registration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ class RegistrationCodeScanner extends StatelessWidget {
return Scaffold(
appBar: AppBar(title: Text(S.of(context).registrationQrScannerTitle)),
body: MobileScanner(
onDetect: (barcode, args) {
var data = barcode.rawValue?.split('\n');
onDetect: (barcode) {
var data = barcode.raw.split('\n');

Check warning on line 158 in lib/src/pages/registration.dart

View check run for this annotation

Codecov / codecov/patch

lib/src/pages/registration.dart#L157-L158

Added lines #L157 - L158 were not covered by tests
if (data == null || data.length != 3) {
throw QrScanError(S.of(context).registrationInvalidQrCode);
}
Expand Down
Loading

0 comments on commit fa5562b

Please sign in to comment.