Dev #17
Dev #17
Conversation
… each value represents a player object
…mafia game player
…e ips and each of it's values contain a player object
…mmodate the new structure of handling players
There was a problem hiding this comment.
That was really nice.
Thanks for your time and efforts 👍
I'll checkout to your dev branch and test it practically and then issue my last review.
I left minor comments, it may attract your attention.
If you have time, I think it would be great if we make a class for Role too.
mafia.py
Outdated
| @@ -11,7 +12,8 @@ | |||
| id = 0 | |||
| nPlayers = 0 | |||
| roles = [] | |||
| ip2role_index_name = {} | |||
| #ip2role_index_name = {} | |||
There was a problem hiding this comment.
You can remove them, don't need to be commented.
mafia.py
Outdated
| else: | ||
| if id > nPlayers: | ||
| return render_template("404.html", is_farsi=True) | ||
| role = roles[id] | ||
| ip2role_index_name[ip] = [role, | ||
| """ip2role_index_name[ip] = [role, |
| self.state = state | ||
| def set_comment(self, comment): | ||
| self.comment = comment | ||
|
|
There was a problem hiding this comment.
Check this line it looks like it needs another new line (code style).
| image_name = role + "_" + str(ip2role_index_name[ip][1]) | ||
| False]""" | ||
| image_name = role + "_" + str(randrange(1, nRoles[role] + 1)) | ||
| ip2players[ip] = Player(ip, username, role, image_name) | ||
| print("*" * 20, "New Player","*" * 20) | ||
| toGod = ip + " : " + str(id) + " : " + username + " --> " + role | ||
| toGod += "/" + role2fa[role] #TODO: Just in Farsi Mode |
There was a problem hiding this comment.
It will be nice if we have a proper text for player informing to God which can be use like this:
toGod = print(ip2players[ip])
Which can be done using __str__ function in Player class.
mafia.py
Outdated
| @@ -11,7 +12,8 @@ | |||
| id = 0 | |||
| nPlayers = 0 | |||
| roles = [] | |||
| ip2role_index_name = {} | |||
| #ip2role_index_name = {} | |||
| ip2players = {} | |||
There was a problem hiding this comment.
How about ip2player?
I mean by the way it's dictionary which maps each ip to a player.
I couldn't agree more. This is actually what I am currently working on. |
That's nice you can work on it too it won't cause any conflict but just in the case you can: and merge |
|
@Thepunisher79 It seems right practically. |
Dear Sadra,
due to the issue #6, I've implemented the basic Player class in player.py which handles mafia players by instantiating this class each time a new user is added to the game. As a result, I had to change mafia.py, GOD.html and Player.html as well to conform to the new structure.