fix: ensure prepare_command only appends one -c arguemnt to shell #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fish errors out on multiple `-c` invocations where zsh, bash don't. It seems somehow multiple are being sent to shell. To workaround this there's a check to only add if it's not present. Signed-off-by: Anthony Rabbito <[email protected]>
…hell" This reverts commit 6427607.
Signed-off-by: Anthony Rabbito <[email protected]>
onedr0p
approved these changes
Sep 25, 2024
|
Fixes #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fish errors out on multiple
-cinvocations where zsh, bash don't.I originally had a check but instead dropped it in app.rs. I very much don't know rust so feel free to adapt as needed :)
Shout out to @onedr0p for figuring out how this was broke and finding the redundant appends <3