Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type declarations to increase phpstan to level 6 #591

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Type declarations to increase phpstan to level 6 #591

wants to merge 18 commits into from

Commits on Nov 15, 2023

  1. Bump dependencies in composer.json

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    01c8169 View commit details
    Browse the repository at this point in the history

  2. Increase phpstan to level 6

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ac9861a View commit details
    Browse the repository at this point in the history

  3. Adjust mostly test code for phpstan level 6

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f773c3f View commit details
    Browse the repository at this point in the history

  4. Declare more types in tests

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f528c4d View commit details
    Browse the repository at this point in the history

  5. Remove useless check of propertyCounters < 1 

    phpstan reports:
 588    Comparison operation "<" between int<1, max> and 1 is always false.

That is correct. The code higher up sets
$propertyCounters[$name] = 1;
and then only ever increments it.
So it can never be less than 1.
    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8cd6d44 View commit details
    Browse the repository at this point in the history

  6. Adjust some type declarations in lib/Component.php

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e1d9b7d View commit details
    Browse the repository at this point in the history

  7. Remove phpstan-ignore-line from lines that no longer give a phpstan e… 

    …rror
    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7569509 View commit details
    Browse the repository at this point in the history

  8. Fixup phpstan errors in lib/Component/VEvent.php

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    4e2f7ce View commit details
    Browse the repository at this point in the history

  9. add ATTENDEE to possible magic properties of VEvent

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ad52e51 View commit details
    Browse the repository at this point in the history

  10. Adjust tests to remove phpstan errors

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9e99568 View commit details
    Browse the repository at this point in the history

  11. Move public string 'name' into Node 

    All of Component, Parameter and Property have 'name'.

Moving it into Node helps phpstan to understand that 'name' always exists.
    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    580ab40 View commit details
    Browse the repository at this point in the history

  12. Add dollar in front of @Property variables

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3425da2 View commit details
    Browse the repository at this point in the history

  13. Fixup phpstan things reported in MainTest

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c18d93b View commit details
    Browse the repository at this point in the history

  14. Fix cs-style

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    18a77ff View commit details
    Browse the repository at this point in the history

  15. Fix things reported by phpstan in tests

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e8757a2 View commit details
    Browse the repository at this point in the history

  16. Adjust types in lib/Writer.php

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d2c7cde View commit details
    Browse the repository at this point in the history

  17. Adjust types in lib/VCardConverter.php

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    18494f5 View commit details
    Browse the repository at this point in the history

  18. Apply cs-fixer changes

    @phil-davis
    phil-davis committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6f8d36e View commit details
    Browse the repository at this point in the history