-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit SablierV2Blast
in Batch and Factory
#341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
staging-blast
branch
from
May 3, 2024 16:22
e428d25
to
c90be33
Compare
feat: configure blast settings in scripts
andreivladbrg
force-pushed
the
feat/inherit-blast
branch
from
May 3, 2024 16:35
a12a8d9
to
80087d1
Compare
smol-ninja
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Feel free to merge it. Just make sure to review my commit d9ab2c8 before merging.
Thank you, looking good. Merging now. |
smol-ninja
added a commit
that referenced
this pull request
Jul 4, 2024
* feat: inherit SablierV2Blast in Batch and Factory contracts * feat: update scripts with admin param feat: configure blast settings in scripts * test: add constructor test in batch and factory * refactor: update precompiles * refactor: blast related changes --------- Co-authored-by: smol-ninja <[email protected]>
smol-ninja
added a commit
that referenced
this pull request
Jul 4, 2024
* feat: inherit SablierV2Blast in Batch and Factory contracts * feat: update scripts with admin param feat: configure blast settings in scripts * test: add constructor test in batch and factory * refactor: update precompiles * refactor: blast related changes --------- Co-authored-by: smol-ninja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-sablier-3/issues/13