Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename Batch to BatchLockup #322

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor: rename Batch to BatchLockup #322

merged 2 commits into from
Apr 12, 2024

Conversation

smol-ninja
Copy link
Member

closes #320

PaulRBerg
PaulRBerg requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested below

test/fork/assets/USDC.t.sol Outdated Show resolved Hide resolved
test/utils/BatchLockupBuilder.sol Outdated Show resolved Hide resolved
test/utils/Defaults.sol Outdated Show resolved Hide resolved
test/utils/DeployOptimized.sol Outdated Show resolved Hide resolved
PaulRBerg
PaulRBerg approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed all of my feedback above in the latest commit. LGTM now.

@PaulRBerg PaulRBerg force-pushed the refactor/batch-lockup branch from 0a8e578 to 31688e8 Compare April 11, 2024 07:01
@smol-ninja smol-ninja force-pushed the refactor/use-abbreviations branch 2 times, most recently from ac75fbb to f8b9cd2 Compare April 11, 2024 13:51
@smol-ninja
Copy link
Member Author

smol-ninja commented Apr 11, 2024 •
edited
Loading

Similar to #321, I will be re-doing it upon prb-feedback changes as there are too many git conflicts. The former is easier to do.

@smol-ninja smol-ninja changed the base branch from refactor/use-abbreviations to staging April 11, 2024 14:33
@PaulRBerg PaulRBerg changed the base branch from staging to 2.2 April 11, 2024 16:21
@PaulRBerg PaulRBerg changed the base branch from 2.2 to staging April 11, 2024 16:21
@smol-ninja smol-ninja force-pushed the refactor/batch-lockup branch from 31688e8 to a47b6f1 Compare April 11, 2024 16:43
@smol-ninja smol-ninja requested a review from PaulRBerg April 11, 2024 16:55
@smol-ninja
Copy link
Member Author

smol-ninja commented Apr 11, 2024 •
edited
Loading

@PaulRBerg can you please have a quick look to this as well?

PS: I have incorporated your suggestions in this PR as well.

@smol-ninja smol-ninja merged commit 7c3ca60 into staging Apr 12, 2024
7 checks passed
@smol-ninja smol-ninja deleted the refactor/batch-lockup branch April 12, 2024 11:06
@andreivladbrg andreivladbrg mentioned this pull request Apr 18, 2024
Open
5 tasks
@andreivladbrg andreivladbrg mentioned this pull request Jul 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreivladbrg andreivladbrg Awaiting requested review from andreivladbrg

@PaulRBerg PaulRBerg Awaiting requested review from PaulRBerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smol-ninja @PaulRBerg