ci: add slither job

[scorpion9979]

Addresses #418.
Recreated from #431.

[scorpion9979]

@andreivladbrg I've updated the GitHub action, as it was failing due to attempting to call forge from the Slither job's Docker container.

Context:

1. job run
2. comment on a slither-action issue

[andreivladbrg]

It looks like the slither job keeps on failing, I had a look and I couldn't figure it out why.

@scorpion9979 can you help us?

[scorpion9979]

@andreivladbrg It seems like the GitHub action is still attempting to call forge from inside the job's Docker container. I found another possible workaround at crytic/slither-action#44 (comment), which I just pushed a commit for. It might take a few trials to get this right.

Update: It was another failed attempt. I'll experiment more and run the workflow in my personal repo. I'll get back to you once I think it's ready, so please feel free to ignore any workflow approval requests for now.

[andreivladbrg]

I'll experiment more and run the workflow in my personal repo. I'll get back to you once I think it's ready

thank you 🙏🏻

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[andreivladbrg]

@scorpion9979 It looks like the slither job has passed.Am I missing something?
The fork tests are failing because you probably don't have set up RPC_URL_MAINNET in the github secrets of your repo.

[scorpion9979]

@andreivladbrg Thanks! I just re-ran all CI jobs after setting up the GitHub secrets in my forked repo and all are now passing. I just double-checked to make sure the Slither job is as clean as possible, and I think this PR is now ready to be reviewed and merged.

[andreivladbrg]

The fork tests have failed again. I've seen on your fork that they worked, and I also tested them locally and they worked.
I'm not sure what the issue is now

[andreivladbrg]

Looks good.

Good job @scorpion9979

[PaulRBerg]

Thanks again for your contribution, @scorpion9979!

@andreivladbrg did you look over the Slither report to check whether it reported something that we should address?

[andreivladbrg]

did you look over the Slither report to check whether it reported something that we should address?

Yeah, I did and found nothing that we should address. You can see the report here.

[PaulRBerg]

Great.

You can see the report here.

Could you please mark all items in the code scan report as "False positive", "Used in tests", or "Won't fix"?