Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/196 block on purchasable #199

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Fix/196 block on purchasable #199

merged 5 commits into from
Nov 20, 2024

Conversation

sabjorn
Copy link
Owner

@sabjorn sabjorn commented Nov 20, 2024

fixes the issue where non-purchasable tracks/albums display "undefined" instead of a + button
adds a feature to skip album/tracks if already purchased

@sabjorn sabjorn requested a review from Sporradik November 20, 2024 21:02
Copy link
Collaborator

@Sporradik Sporradik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -24,6 +25,7 @@ export default class Player {
this.createInputButtonPair = createInputButtonPair;
this.createShoppingCartItem = createShoppingCartItem;
this.extractBandFollowInfo = extractBandFollowInfo;
this.extractFanTralbumData = extractFanTralbumData;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is tralbum? It looks like this is a thing and not a typo, so curious what it means

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's Bandcamp's internal term for a track or album (trrackalbum)

@sabjorn sabjorn merged commit 81315b8 into main Nov 20, 2024
1 check passed
@sabjorn sabjorn deleted the fix/196-block-on-purchasable branch November 20, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants