Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/145 import export cart #195

Merged
merged 28 commits into from
Nov 20, 2024
Merged

Feature/145 import export cart #195

merged 28 commits into from
Nov 20, 2024

Conversation

sabjorn
Copy link
Owner

@sabjorn sabjorn commented Nov 10, 2024

adds buttons to cart for "import" and "export"

additionally -- moves the 'reset' button from the 1-click add to cart feature over to this new cart "page" component

@sabjorn sabjorn force-pushed the feature/145-import-export-cart branch from 8fb4721 to 0d368d8 Compare November 10, 2024 21:19
@sabjorn sabjorn force-pushed the feature/145-import-export-cart branch 2 times, most recently from 9a31f1d to 7432699 Compare November 18, 2024 00:45
…tation to prevent page reload if nothing actually called
@sabjorn sabjorn force-pushed the feature/145-import-export-cart branch from a1b44e8 to 77efca8 Compare November 20, 2024 03:10
@sabjorn sabjorn marked this pull request as ready for review November 20, 2024 04:28
@sabjorn sabjorn requested a review from emcniece November 20, 2024 04:29
@sabjorn sabjorn requested a review from Sporradik November 20, 2024 04:29
src/player.js Show resolved Hide resolved
test/cart.js Show resolved Hide resolved
test/cart.js Outdated Show resolved Hide resolved
test/cart.js Outdated Show resolved Hide resolved
@sabjorn sabjorn merged commit 35d681f into main Nov 20, 2024
1 check passed
@sabjorn sabjorn deleted the feature/145-import-export-cart branch November 20, 2024 16:32
sabjorn added a commit that referenced this pull request Nov 20, 2024
add ability to import and export cart

this is done by providing buttons attached to the cart item on any page. The export will generate a JSON file and the import will handle this JSON file.

additionally -- the reset button from the 1-click buy feature has been moved over to this component. If the cart has been modified -- exporting is not allow and the reset button is show. Otherwise, the reset button is hidden and the export button is visible

additionally:
* move download file function to utilits
* move dateString function to utilities
* update date format for cart and downloads to be yy-mm-dd
* move re-usable static method to component and re-name component to be for button types
* update download_helper and tests for previous changes
* fix potential failure mode of Player and add test
* update Player 1-click feature with a small fix and add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant