-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/145 import export cart #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabjorn
force-pushed
the
feature/145-import-export-cart
branch
from
November 10, 2024 21:19
8fb4721
to
0d368d8
Compare
sabjorn
force-pushed
the
feature/145-import-export-cart
branch
2 times, most recently
from
November 18, 2024 00:45
9a31f1d
to
7432699
Compare
…ause cart is shared
… for button types
…rt has been modified
…tion so this tests passes
…tation to prevent page reload if nothing actually called
sabjorn
force-pushed
the
feature/145-import-export-cart
branch
from
November 20, 2024 03:10
a1b44e8
to
77efca8
Compare
sabjorn
commented
Nov 20, 2024
sabjorn
commented
Nov 20, 2024
sabjorn
commented
Nov 20, 2024
sabjorn
commented
Nov 20, 2024
sabjorn
added a commit
that referenced
this pull request
Nov 20, 2024
add ability to import and export cart this is done by providing buttons attached to the cart item on any page. The export will generate a JSON file and the import will handle this JSON file. additionally -- the reset button from the 1-click buy feature has been moved over to this component. If the cart has been modified -- exporting is not allow and the reset button is show. Otherwise, the reset button is hidden and the export button is visible additionally: * move download file function to utilits * move dateString function to utilities * update date format for cart and downloads to be yy-mm-dd * move re-usable static method to component and re-name component to be for button types * update download_helper and tests for previous changes * fix potential failure mode of Player and add test * update Player 1-click feature with a small fix and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds buttons to cart for "import" and "export"
additionally -- moves the 'reset' button from the 1-click add to cart feature over to this new
cart
"page" component