feat: add support for typescript pages and components #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saber ready! Built with commit a8e8f07 |
This was referenced Nov 7, 2019
|
Any ETA on when we could expect this to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #128
You can now write
.tsand.tsxpages in./pagesfolder,<script lang="ts">is also supported in.vuepages and normal.vuecomponents.This is implemented with
@babel/preset-typescript, so it does transformation without type checking.Following features will be introduced in the future.- Detect
- Use
- Automatically generate
TODOs:
tsconfig.jsonand if it exists:fork-ts-checker-webpack-pluginfor type-checkingsaber-env.d.tsto include types forsaber/configetcWhat kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix: rebuild when a page is addedTo avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: