fix: remove invalid character for XML feed; fix #537 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saber ready! Built with commit 84b29bb |
nblthree
reviewed
Oct 30, 2019
| */ | ||
| exports.removeXMLInvalidChars = (string, removeDiscouragedChars = true) => { | ||
| // remove everything forbidden by XML 1.0 specifications, plus the unicode replacement character U+FFFD | ||
| var regex = /((?:[\0-\x08\x0B\f\x0E-\x1F\uFFFD\uFFFE\uFFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])|(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF]))/g |
There was a problem hiding this comment.
change var to let and disable unicorn/no-hex-escape and no-control-regex rules in package.json you can also do /* eslint-disable no-control-regex */ before this line instead
egoist
reviewed
Oct 31, 2019
| * @param {string} string - a string potentially containing XML-invalid characters, such as non-UTF8 characters, STX, EOX and so on. | ||
| * @param {boolean} removeDiscouragedChars - a string potentially containing XML-invalid characters, such as non-UTF8 characters, STX, EOX and so on. | ||
| * @return : a sanitized string without all the XML-invalid characters. | ||
| */ |
There was a problem hiding this comment.
Can you add a reference to those RegExp?
|
I opened an issue to see if it's possible to be fixed by the upstream jpmonette/feed#107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
close #537