Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transform vue template with posthtml #479

Merged
merged 9 commits into from
Sep 27, 2019
Merged

feat: transform vue template with posthtml #479

merged 9 commits into from
Sep 27, 2019

Conversation

egoist
Copy link
Collaborator

@egoist egoist commented Sep 26, 2019

Summary

By transforming Vue template with PostHTML, Saber could add features for all types of pages at the same time.

For example, previously you can only use relative link to resolve page in markdown:

[About](./about.md)

This was implemented in a markdown plugin and only works for markdown page.

Now you can also use <saber-link>:

<saber-link to="./about.md">About</saber-link>

Or even using <a> directly:

<a href="./about.md">About</a>

<a> is converted to <saber-link> now if it's not an external link, so we will use <a> in docs and examples in the future.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:


Fixes #474 Fixes #460.

#472 can now be implemented as a PostHTML plugin instead.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for saber ready!

Built with commit f14d3c0

https://deploy-preview-479--saber.netlify.com

@egoist egoist merged commit b56296a into saberland:master Sep 27, 2019
@egoist egoist deleted the feat/template branch September 27, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete support for relative links in Markdown page Windows path issue in $saber.getPageLink
1 participant