Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move CI to GitHub actions #451

Merged
merged 17 commits into from
Nov 2, 2019
Merged

build: move CI to GitHub actions #451

merged 17 commits into from
Nov 2, 2019

Conversation

egoist
Copy link
Collaborator

@egoist egoist commented Sep 14, 2019

Summary

Closes #436

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

@netlify
Copy link

netlify bot commented Sep 14, 2019

Deploy preview for saber ready!

Built with commit 18d8445

https://deploy-preview-451--saber.netlify.com

@egoist
Copy link
Collaborator Author

egoist commented Sep 14, 2019

Great, except that GitHub actions is 1 minute slower than CirCleCI because it didn't cache node_modules 🤔

@egoist
Copy link
Collaborator Author

egoist commented Sep 14, 2019

Hmm not sure why Prettier is complaining about carriage returns on Windows: https://github.com/saberland/saber/pull/451/checks?check_run_id=222280251#step:5:16

@nblthree
Copy link
Member

nblthree commented Sep 14, 2019

@egoist it happens for me locally. Running xo --fix fixed it but there is nothing to commit here is the branch https://github.com/MarchWorks/saber/tree/xofix but when I do git fetch uptream then git reset --hard upstream/master and run yarn test the errors don't show up

@egoist
Copy link
Collaborator Author

egoist commented Nov 2, 2019

@the94air sorry for spamming you 😆

@egoist egoist merged commit 3e17d29 into master Nov 2, 2019
@egoist egoist deleted the build/actions-ci branch November 2, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI to GitHub actions
3 participants