Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #343 #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix #343 #422

wants to merge 2 commits into from

Conversation

sbencoding
Copy link

@sbencoding sbencoding commented Sep 7, 2019

Summary
This PR adds a proxy plugin to saber that acts like the webpack devServer proxy specified in issue #343

  • Adds a simple and quick way to proxy requests to an API server in a development environment
  • Client code can reference the API the same way in development and production (e.g. the client code doesn't have to determine the actual host:port of the API, it can fetch /api directly and the backend will figure out the server to connect to.)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome (76.0.3809.132)
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
I'm new to this project, so it is possible that I didn't follow some convention/best practice this project follows, if so, please let me know so I can fix it 😅


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@netlify
Copy link

netlify bot commented Sep 7, 2019

Deploy preview for saber ready!

Built with commit 2a06a8a

https://deploy-preview-422--saber.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant