Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scoped package support #362

Merged
merged 2 commits into from
Aug 20, 2019
Merged

fix scoped package support #362

merged 2 commits into from
Aug 20, 2019

Conversation

saltysugar
Copy link
Contributor

@saltysugar saltysugar commented Aug 15, 2019

Summary

Close #360

Valid formats:

  • foo
  • @user/foo

Automatically add prefix when specified.

It means we can use foo or saber-theme-foo or @user/foo or @user/saber-theme-foo to load a theme from npm package.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI/CSS related code, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@netlify
Copy link

netlify bot commented Aug 15, 2019

Deploy preview for saber ready!

Built with commit ff13c36

https://deploy-preview-362--saber.netlify.com

@krmax44 krmax44 added the bug Something isn't working label Aug 19, 2019
@egoist egoist merged commit 4250842 into saberland:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use scope package for theme.
3 participants