-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #151: Show headings in the sidebar #167
Conversation
Deploy preview for saber ready! Built with commit 4d2e31a |
I think it means adding a hamburger menu style button to allow collapsing it even on a desktop |
I just think that there is no need to do that because it became collapsible when the window inner width is inferior to 768px |
Seems that the deployment fell when importing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good 👍 Only some code style aspects that could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I have refactored some bits to make it cleaner and easier to understand and I tweaked some design aspects. Only remaining issue: when scrolling, the page jumps a bit because scrolling changes the hash and changing the hash changes the scroll position. So we need to decouple that.
You made some good changes but some I don't like I will wait until @egoist decide what he wants |
merge branch master into sidebar
Summary
Closes #151
What kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: