feat: add default document title and meta description #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saber ready! Built with commit f545e29 |
egoist
reviewed
Nov 7, 2019
| name: 'description', | ||
| content: `${this.$siteConfig.description || 'A framework for building modern static websites'}` | ||
| } | ||
| ] |
There was a problem hiding this comment.
I guess we don't need to set a default title and description. They're irrelevant to user's project.
There was a problem hiding this comment.
I guess we don't need to set a default title and description. They're irrelevant to user's project.
Sorry for the delay, I will add conditional statements, check it again. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #555
What kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix: rebuild when a page is addedTo avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: