Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting default document title and meta description #555

Closed
egoist opened this issue Nov 6, 2019 · 4 comments · Fixed by #556
Closed

Setting default document title and meta description #555

egoist opened this issue Nov 6, 2019 · 4 comments · Fixed by #556

Comments

@egoist
Copy link
Collaborator

egoist commented Nov 6, 2019

Feature request

What problem does this feature solve?

Adding default <title> and <meta name="description"> based on siteConfig.title and siteConfig.description in your Saber config file.

How should this be implemented in your opinion?

Adding them to root Vue instance:

@the94air
Copy link

the94air commented Nov 6, 2019

That's a good idea. We probably do that on every application! Nothings here! Whistling

@0xinhua
Copy link
Contributor

0xinhua commented Nov 6, 2019

@egoist Hi, I wanna try to contribute code for this feature : )

@egoist
Copy link
Collaborator Author

egoist commented Nov 6, 2019

@M1sery 👬 Let's do it

@0xinhua
Copy link
Contributor

0xinhua commented Nov 7, 2019

@egoist check #pr556

It is always nice to try new things, it's my first time to use Saber ( writing my blog with Hexo before), I really looking forward to doing more things for this project ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants