Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support line number in code blocks #178

Closed
egoist opened this issue May 12, 2019 · 4 comments
Closed

feature: support line number in code blocks #178

egoist opened this issue May 12, 2019 · 4 comments
Assignees
Labels
contribution welcome 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt good first issue Good for newcomers type: feature

Comments

@egoist
Copy link
Collaborator

egoist commented May 12, 2019

Issuehunt badges

Feature request

What problem does this feature solve?

Show line numbers in code blocks.

What does the proposed API look like?

Globally enabled:

markdown:
  lineNumbers: true

Toggle line numbers per code block:

```js {lineNumbers:true}
console.log(42)
```

How should this be implemented in your opinion?

Implement it in the markdown/highlight-plugin.js

Are you willing to work on this yourself?

If no one else will.

IssueHunt Summary

lubien lubien has been rewarded.

Sponsors (Total: $40.00)

Tips

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 13, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@krmax44 krmax44 self-assigned this May 13, 2019
lubien added a commit to lubien/saber that referenced this issue May 29, 2019
* highlight-plugin.js now read global and local { lineNumber: true}.
* Added tests and snapshots for the feature.
* Receive and validate lineNumber from markdown settings.
* Add some CSS for the line numbers.
* Document both the markdown config and the inline option.
@egoist egoist closed this as completed in 1561c61 May 29, 2019
@krmax44
Copy link
Contributor

krmax44 commented May 29, 2019

@lubien Don't forget to grab your bounty at Issuehunt 😄

@lubien
Copy link
Contributor

lubien commented May 29, 2019

@krmax44 Oh, yea. I think it has some delay time because it's pending so I'm just waiting.

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 29, 2019
@IssueHuntBot
Copy link

@egoist has rewarded $28.00 to @lubien. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(20%): $8.00
  • 🔧 Service fee(10%): $4.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt good first issue Good for newcomers type: feature
Projects
None yet
Development

No branches or pull requests

4 participants