Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update Czech #962

Merged
merged 2 commits into from
Oct 30, 2023
Merged

i18n: Update Czech #962

merged 2 commits into from
Oct 30, 2023

Conversation

ceskyDJ
Copy link
Contributor

@ceskyDJ ceskyDJ commented Oct 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1f6577) 32.70% compared to head (ef7c6bc) 32.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   32.70%   32.62%   -0.08%     
==========================================
  Files         102      102              
  Lines        7522     7522              
==========================================
- Hits         2460     2454       -6     
- Misses       5062     5068       +6     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Oct 22, 2023

@adil192, there is a little problem. We need to specify multiple variations of strings "Move $n notes" and "$n notes will be renamed" for different intervals of $n.

For Czech it is:

Move $n notes

1: Přesunout 1 poznámku
2--4: Přesunout $n poznámky
5+: Přesunout $n poznámek

$n notes will be renamed

1: Bude přejmenována 1 poznámka
2--4: Budou přejmenovány $n poznámky
5+: Bude přejmenováno $n poznámek

adil192 added a commit that referenced this pull request Oct 28, 2023
@adil192
Copy link
Member

adil192 commented Oct 28, 2023

We'll now only need the 5+ intervals :)

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Oct 28, 2023

I'm sorry, but I didn't get it. Could you describe it in more detail, please?

@adil192
Copy link
Member

adil192 commented Oct 29, 2023

The 2 strings you mentioned will only be used if there are 5 or more notes

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Oct 29, 2023

Ah, ok. Nice, thanks!

@ceskyDJ ceskyDJ marked this pull request as ready for review October 29, 2023 19:15
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Oct 29, 2023

So, it's ready for merge :D.

@adil192 adil192 enabled auto-merge (squash) October 30, 2023 15:09
@adil192 adil192 merged commit d611d29 into saber-notes:main Oct 30, 2023
2 checks passed
@ceskyDJ ceskyDJ deleted the patch-43 branch October 30, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants