[FEATURE] Add MigrateViewHelperRenderStaticRector #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw locally that there are still some phpstan issues. As the rule is already quite complex, fixing those could make it even more difficult to understand. But let me know if and how I should address those. |
|
@s2b Thank you so much. I have already seen your standalone repository. Great work. I will have a look at it soon. |
|
@simonschaufi I haved fixed all the errors. Could you have a quick look at the rule? I would really like to merge it. Very useful rule |
This rector rule covers the majority of use cases where the now deprecated `renderStatic()` is used in Fluid ViewHelper classes. It's the same rule that has been used in the TYPO3 Core patch that migrated all existing ViewHelpers to `render()`. There were some edge cases in the TYPO3 Core that weren't covered, but those are rather old and don't follow recent best practices. Core Patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85834
simonschaufi
approved these changes
Sep 27, 2024
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rector rule covers the majority of use cases where the now deprecated
renderStatic()is used in Fluid ViewHelper classes. It's the same rule that has been used in the TYPO3 Core patch that migrated all existing ViewHelpers torender(). There were some edge cases in the TYPO3 Core which weren't covered, but those are rather old and don't follow recent best practices.Core Patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85834
Fixes: #4346