Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix wrong eval removal on TCA datetime migration #4138

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

helsner
Copy link
Collaborator

@helsner helsner commented Mar 5, 2024

Resolves: #4137

@helsner
Copy link
Collaborator Author

helsner commented Mar 5, 2024

have to fix this, right now its just the broken test

@helsner helsner force-pushed the issue-4137 branch 2 times, most recently from 18e3c7b to 0cfc944 Compare March 5, 2024 09:25
@helsner helsner marked this pull request as ready for review March 5, 2024 09:26
@simonschaufi
Copy link
Collaborator

simonschaufi commented Mar 5, 2024

What exactly is the bug here? I was implementing exactly the same like the core.

PS: wrongful has a different meaning than "wrong".

@helsner
Copy link
Collaborator Author

helsner commented Mar 5, 2024

The issue is that we cannot remove the required eval within this rector.
We have one for the Datetime Migration and one for the required => true migration
But if the Datetime Migration runs before the eval => required to required => true one, then the value is getting kicked.
eval => null has the same behavior, but we handle it properly and the Nullable TCA Rector does its job afterwards

@simonschaufi simonschaufi changed the title [BUGFIX] Resolve wrongful eval removal on TCA datetime migration [BUGFIX] Fix wrong eval removal on TCA datetime migration Mar 7, 2024
@simonschaufi simonschaufi merged commit d9d7933 into main Mar 7, 2024
28 checks passed
@simonschaufi simonschaufi deleted the issue-4137 branch March 7, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falsely removal of eval on datetime migration
2 participants