-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Return multiple nodes instead of using NodesToAddCollector #3983
Conversation
f67cace
to
2eb7c21
Compare
@simonschaufi We should either remove some complex rarely used rules which uses the NodesToAddCollector or refactor them. This can be quite cumbersome but we should move forward. |
7b568c9
to
9f215cd
Compare
@sabbelasichon The title of the issue doesn't make it clear that it also removes some rules. Why did you actually remove them? |
Too old. Never used them. Never seen them in the wild tbh. Drop complexity. Let us focus on important things |
ok but then we should also mark the commits somehow because we also don't really follow semver at the moment. |
I don't really care. Being pragmatic in that regard |
Relates: #3982