Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Return multiple nodes instead of using NodesToAddCollector #3983

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

sabbelasichon
Copy link
Owner

Relates: #3982

@sabbelasichon
Copy link
Owner Author

sabbelasichon commented Jan 3, 2024

@simonschaufi We should either remove some complex rarely used rules which uses the NodesToAddCollector or refactor them. This can be quite cumbersome but we should move forward.

@sabbelasichon sabbelasichon changed the title TASK: Return multiple nodes for Rector BackendUtilityGetRecordRawRector TASK: Return multiple nodes instead of using NodesToAddCollector Jan 3, 2024
@sabbelasichon sabbelasichon merged commit afb3b7c into main Jan 3, 2024
16 checks passed
@sabbelasichon sabbelasichon deleted the issue-3982 branch January 3, 2024 20:50
@simonschaufi
Copy link
Collaborator

@sabbelasichon The title of the issue doesn't make it clear that it also removes some rules. Why did you actually remove them?

@sabbelasichon
Copy link
Owner Author

sabbelasichon commented Jan 3, 2024

Too old. Never used them. Never seen them in the wild tbh. Drop complexity. Let us focus on important things

@simonschaufi
Copy link
Collaborator

ok but then we should also mark the commits somehow because we also don't really follow semver at the moment.

@sabbelasichon
Copy link
Owner Author

I don't really care. Being pragmatic in that regard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants