Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Extract type converters to services.yaml #3212

Merged
merged 2 commits into from
Nov 13, 2022
Merged

TASK: Extract type converters to services.yaml #3212

merged 2 commits into from
Nov 13, 2022

Conversation

sabbelasichon
Copy link
Owner

@sabbelasichon sabbelasichon commented Nov 12, 2022 •
edited
Loading

Resolves: #2859

@sabbelasichon sabbelasichon changed the title TASK: Extract type converters to services.yaml DRAFT: TASK: Extract type converters to services.yaml Nov 12, 2022
@sabbelasichon
Copy link
Owner Author

sabbelasichon commented Nov 12, 2022 •
edited
Loading

The only missing piece is to remove the obsolete methods on the type converter classes

Done

@sabbelasichon sabbelasichon force-pushed the issue-2859 branch 4 times, most recently from 53a4759 to b0f9c1c Compare November 13, 2022 18:51
@sabbelasichon sabbelasichon changed the title DRAFT: TASK: Extract type converters to services.yaml TASK: Extract type converters to services.yaml Nov 13, 2022
@sabbelasichon sabbelasichon merged commit ca72ca1 into main Nov 13, 2022
@sabbelasichon sabbelasichon deleted the issue-2859 branch November 13, 2022 19:03
@sabbelasichon sabbelasichon mentioned this pull request Nov 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helsner helsner Awaiting requested review from helsner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking: #94117 - Register extbase type converters as services
1 participant
@sabbelasichon