[TASK] Load stubs via phpstan (#2200)

* [TASK] Use static reflection

* [TASK] Add stubs for Migrations

captainhook.json

@@ -10,11 +10,6 @@
     "pre-commit": {
         "enabled": true,
         "actions": [
-            {
-                "action": "\\CaptainHook\\App\\Hook\\PHP\\Action\\Linting",
-                "options": [],
-                "conditions": []
-            },
             {
                 "action": "composer run check-style",
                 "options": [],

composer.json

@@ -43,11 +43,9 @@
             "Ssch\\TYPO3Rector\\Tests\\": "tests",
             "Ssch\\TYPO3Rector\\PHPStan\\Tests\\": "utils/phpstan/tests",
             "Ssch\\TYPO3Rector\\Rules\\Tests\\": "utils/rules/tests",
-            "Ssch\\TYPO3Rector\\Rules\\": "utils/rules/src"
+            "Ssch\\TYPO3Rector\\Rules\\": "utils/rules/src",
+            "Ssch\\TYPO3Rector\\Stubs\\": "utils/stubs/src"
         },
-        "classmap": [
-            "stubs"
-        ],
         "exclude-from-classmap": [
             "**.php.inc"
         ]

config/solr/solr_php_client_to_solarium.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use ApacheSolrForTypo3\Solr\System\Solr\Document\Document;
 use ApacheSolrForTypo3\Solr\System\Solr\ResponseAdapter;
 use Rector\Renaming\Rector\Name\RenameClassRector;
 use Ssch\TYPO3Rector\Rector\Extensions\solr\ApacheSolrDocumentToSolariumDocumentRector;
@@ -17,7 +16,7 @@
         ->class(RenameClassRector::class)
         ->call('configure', [[
             RenameClassRector::OLD_TO_NEW_CLASSES => [
-                Apache_Solr_Document::class => Document::class,
+                'Apache_Solr_Document' => 'ApacheSolrForTypo3\Solr\System\Solr\Document\Document',
                 Apache_Solr_Response::class => ResponseAdapter::class,
             ],
         ]]);

ecs.php

@@ -42,6 +42,8 @@
         __DIR__ . '/utils',
     ]);
 
+    $parameters->set(Option::SKIP, [__DIR__ . '/utils/stubs/templates']);
+
     $services = $containerConfigurator->services();
 
     $services->set(LineLengthFixer::class);

rector.php

@@ -18,8 +18,6 @@
     $parameters->set(Option::AUTO_IMPORT_NAMES, true);
     $parameters->set(Option::PHPSTAN_FOR_RECTOR_PATH, __DIR__ . '/phpstan.neon');
 
-    $parameters->set(Option::AUTOLOAD_PATHS, [__DIR__ . '/stubs']);
-
     $services = $containerConfigurator->services();
 
     $services->set(AddCodeCoverageIgnoreToMethodRectorDefinitionRector::class);

src/Rector/v10/v0/UseControllerClassesInExtbasePluginsAndModulesRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
+use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\ObjectType;
 use Rector\Core\Rector\AbstractRector;
 use Ssch\TYPO3Rector\Helper\StringUtility;
@@ -153,8 +154,10 @@ private function createNewControllerActionsArray(
                 continue;
             }
 
-            // If already transformed
-            if (class_exists($controllerClassName)) {
+            $controllerClassNameType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($controllerActions->key);
+
+            if ($controllerClassNameType instanceof ConstantStringType) {
+                // Already transformed
                 continue;
             }
 

src/Rector/v9/v0/MetaTagManagementRector.php

@@ -10,7 +10,6 @@
 use PhpParser\Node\Scalar\String_;
 use PHPStan\Type\ObjectType;
 use Rector\Core\Rector\AbstractRector;
-use ReflectionClass;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 use TYPO3\CMS\Backend\Template\DocumentTemplate;
@@ -158,13 +157,6 @@ private function createXUCompatibleMetaTag(MethodCall $methodCall): MethodCall
         $value = 'IE=8';
         if (count($methodCall->args) > 0) {
             $value = $methodCall->args[0]->value;
-        } else {
-            $classReflection = new ReflectionClass(DocumentTemplate::class);
-            $defaultProperties = array_values($classReflection->getDefaultProperties());
-
-            if (count($defaultProperties) > 0) {
-                $value = $defaultProperties[0];
-            }
         }
 
         return $this->nodeFactory->createMethodCall(

stubs/Migrations/AbstractAuthenticationService.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Sv;
+
+if (class_exists(AbstractAuthenticationService::class)) {
+    return;
+}
+
+final class AbstractAuthenticationService
+{
+
+}

stubs/Migrations/AbstractComposedSalt.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Saltedpasswords\Salt;
+
+if (class_exists(AbstractComposedSalt::class)) {
+    return;
+}
+
+final class AbstractComposedSalt
+{
+
+}

stubs/Migrations/AbstractConditionViewHelper.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Fluid\Core\ViewHelper;
+
+if (class_exists(AbstractConditionViewHelper::class)) {
+    return;
+}
+
+final class AbstractConditionViewHelper
+{
+
+}

stubs/Migrations/AbstractNode.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Fluid\Core\Parser\SyntaxTree;
+
+if (class_exists(AbstractNode::class)) {
+    return;
+}
+
+final class AbstractNode
+{
+
+}

stubs/Migrations/AbstractSalt.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Saltedpasswords\Salt;
+
+if (class_exists(AbstractSalt::class)) {
+    return;
+}
+
+final class AbstractSalt
+{
+
+}

stubs/Migrations/AbstractTagBasedViewHelper.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Fluid\Core\ViewHelper;
+
+if (class_exists(AbstractTagBasedViewHelper::class)) {
+    return;
+}
+
+final class AbstractTagBasedViewHelper extends AbstractViewHelper
+{
+
+}

stubs/Fluid/Core/ViewHelper/AbstractViewHelper.php → stubs/Migrations/AbstractViewHelper.php

@@ -8,6 +8,7 @@
     return;
 }
 
-class AbstractViewHelper
+final class AbstractViewHelper
 {
+
 }

stubs/Migrations/AdminPanelView.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Frontend\View;
+
+if (class_exists(AdminPanelView::class)) {
+    return;
+}
+
+final class AdminPanelView
+{
+
+}

stubs/Migrations/AdminPanelViewHookInterface.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace TYPO3\CMS\Frontend\View;;
+
+if (interface_exists(AdminPanelViewHookInterface::class)) {
+    return;
+}
+
+interface AdminPanelViewHookInterface
+{
+}

stubs/Migrations/AjaxLogin.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+
+
+if (class_exists(AjaxLogin::class)) {
+    return;
+}
+
+final class AjaxLogin
+{
+
+}

stubs/Migrations/AjaxLoginHandler.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Backend;
+
+if (class_exists(AjaxLoginHandler::class)) {
+    return;
+}
+
+final class AjaxLoginHandler
+{
+
+}

stubs/Migrations/Argon2iSalt.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Saltedpasswords\Salt;
+
+if (class_exists(Argon2iSalt::class)) {
+    return;
+}
+
+final class Argon2iSalt
+{
+
+}

stubs/Migrations/ArgumentDefinition.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Fluid\Core\ViewHelper;
+
+if (class_exists(ArgumentDefinition::class)) {
+    return;
+}
+
+final class ArgumentDefinition
+{
+
+}

stubs/Migrations/ArrayBrowser.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Lowlevel\Utility;
+
+if (class_exists(ArrayBrowser::class)) {
+    return;
+}
+
+final class ArrayBrowser
+{
+
+}

stubs/Migrations/AuthenticationService.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Sv;
+
+if (class_exists(AuthenticationService::class)) {
+    return;
+}
+
+final class AuthenticationService
+{
+
+}

stubs/Migrations/AutoPublishTask.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Version\Task;
+
+if (class_exists(AutoPublishTask::class)) {
+    return;
+}
+
+final class AutoPublishTask
+{
+
+}

stubs/Migrations/BaseTestCase.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Extbase\Tests\Unit;
+
+if (class_exists(BaseTestCase::class)) {
+    return;
+}
+
+final class BaseTestCase
+{
+
+}

stubs/Migrations/BcryptSalt.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Saltedpasswords\Salt;
+
+if (class_exists(BcryptSalt::class)) {
+    return;
+}
+
+final class BcryptSalt
+{
+
+}

stubs/Migrations/BlowfishSalt.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Saltedpasswords\Salt;
+
+if (class_exists(BlowfishSalt::class)) {
+    return;
+}
+
+final class BlowfishSalt
+{
+
+}

stubs/Migrations/CannotInitializeCacheException.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace TYPO3\CMS\Extbase\Object\Container\Exception;
+
+if (class_exists(CannotInitializeCacheException::class)) {
+    return;
+}
+
+final class CannotInitializeCacheException
+{
+
+}