Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key value interface, attribute paths, attribute caching #102

Merged
merged 255 commits into from
Jun 27, 2023
Merged

Key value interface, attribute paths, attribute caching #102

merged 255 commits into from
Jun 27, 2023

Conversation

bogovicj
Copy link
Contributor

This supersedes #77

axtimwalde and others added 30 commits April 29, 2021 17:39
@axtimwalde
WIP FS reader implemented?
dcc33e7
@axtimwalde
WIP fs writer (does not work)
7d1ddf6
@axtimwalde
WIP still on it...
d52011e
@axtimwalde
fix license headers in tests
50ad324
@axtimwalde
passing test
9261424
@axtimwalde
replace project.version by n5-spec.version=2.6.1 for spec version
1f49043 
auto-generate current year in license
@axtimwalde
fix some tests and add unspecific cache test (tests cache
39f16c7 
sensitive ops twice with a caching writer)
@axtimwalde
remove non abstract abstract leftover classes, bugfixes
604ad1f
@axtimwalde
list caching
e015bb7 
TODO implement updates in create and remove methods
@axtimwalde
insert root cache entry at writer creation ...
f01d5e5 
TODO shouldn't readers do that too?
@axtimwalde
run writer constructor through createGroup("/")
25bb2e5
@axtimwalde
move trivial remove() implementation into interface default
274cad0
@axtimwalde
add children to parent cache when creating a group
8a53377
@axtimwalde
update parent cache on remove
24e663e 
TODO fails deepList test for a mix of test and implementation issues
@axtimwalde
all tests passing with and without cache
2158733
@axtimwalde
remove dead middle interface GsonAttributesParser
3844e0c
@axtimwalde
Merge branch 'master' into cache-attributes
0aa1b57 
# Conflicts:
#	README.md
#	pom.xml
@axtimwalde
WIP key value interface as filesystem simplification
3ac189d
@axtimwalde
WIP key value access interface (and file system implementation)
1c4ed55
@axtimwalde
This seems to work flawlessly
b5a70af
@axtimwalde
feat: add and use KeyValuAccess path compose method
a0988c6 
abstracts further to platform dependent separation strings
(e.g. "/" vs "\"). The resulting path string is now strictly a platform
dependent path and should not be used in code where a platform
independent string is expected.  Thanks to the Windows FileSystem
implementation accepting "/" separated paths, this should not cause
pracitcal issues at this time but we may have to change the API to support
other FileSystems (e.g. passing paths along as components instead of
strings or settling on a nio Path like object).
@axtimwalde
feat: LockedChannel.openForWriting creates the full path, this is
9268b4c 
  better on key value stores that do not really have paths.

TODO check for leftover redundant path creation, that wouldn't break
  things but makes an unnecessary exists test
@axtimwalde
bump to pom-scijava-31.1.0
7e527eb
@bogovicj
feat: wip add failing test for getting attributes from urls
f849bdc
@cmhulbert
feat: initial N5Url API
31f360c
@bogovicj
test: update test for getting attributes to use N5URL
fa78a76
@cmhulbert
feat: initial N5URL relativize support
52e4add
@cmhulbert
feat: getAttribute from url
6c4e70d
@cmhulbert
test: N5URL tests
02cc783
@bogovicj
test: test object parsing from urls
ead786d
bogovicj and others added 28 commits June 13, 2023 11:43
@bogovicj
Merge branch 'fix/windowPaths' of github.com:saalfeldlab/n5 into fix/…
9a7a621 
…windowPaths
@cmhulbert
fix: more windows path issues
6949209
@bogovicj
doc/chore: add documentation and minor clean up
d14fe55
@cmhulbert
throw N5Exception if list is called on a path that isn't a group
821ee0a
@bogovicj
test: that N5Exception is thrown if list is called on a path that isn…
ac52633 
…'t a group
@bogovicj
doc: when N5Reader methods throw exceptions
4efd741
@cmhulbert
ci: run tests on windows and ubuntu
a0325ad
@bogovicj
Merge pull request #101 from saalfeldlab/feat/windowsActions
e50c27e 
Feat/windows actions
@cmhulbert
ci: build on windows also
e1eebd6
@cmhulbert
feat!: throw exceptions when attempting to parse an attribute with an…
3fdde34 
… incompatible type
@cmhulbert
doc: cleanup
a3de0af
@cmhulbert
style: whitespace, imports
0ce652b
@cmhulbert
feat(test): add write and remove cache tracking tests
2513c1b
@cmhulbert
feat(test): ensure result URI can be used to get a new reader over th…
4924308 
…e same container
@cmhulbert
fix(test): close more reader/writers
27d9278
@cmhulbert
fix(test): test was reading and testing the incorrect attribute key
b637363
@cmhulbert
refactor(test): better test patterns
33a0990
@cmhulbert
Revert "BREAKING: rm default groupPath impl in N5Reader"
9347fd0 
This reverts commit ccda98e
@cmhulbert
test: restrict delta for double equivalence
39172a8
@cmhulbert
feat(test): ensure temporary containers are deleted when no longer ne…
2261c5a 
…eded
@cmhulbert
feat(test): don't use static n5 container
51b2e24
@bogovicj
fix: normalize attr path in rmAttributes
60e2ae8
@bogovicj
doc: typo fixes
cfaffae
@cmhulbert
feat(test): don't use static n5
eed9042
@cmhulbert
feat(test): remove static n5 reference
a6ab3f2
@cmhulbert
docs: remove some javadoc warnings
8bc9a25
@bogovicj
doc: add and clarify javadoc
bbfe0f3 
* N5Reader
* LockedChannel
* KeyValueAccess
* FileSystemKeyValueAccess
@cmhulbert
doc: more javadoc warnings
e81ce86
@bogovicj bogovicj merged commit 7a333a3 into master Jun 27, 2023
@cmhulbert cmhulbert deleted the wip/KeyValueInterface branch December 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogovicj @axtimwalde @cmhulbert @tpietzsch