Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action sometimes suggests downgrades #25

Closed
starikcetin opened this issue Oct 20, 2022 · 3 comments
Closed

This action sometimes suggests downgrades #25

starikcetin opened this issue Oct 20, 2022 · 3 comments

Comments

@starikcetin
Copy link

starikcetin commented Oct 20, 2022

Sometimes actions backport some features to previous major versions, and this action is offering them in the PRs, essentially meaning it would downgrade the version if merged.

As far as I understand this is due to not parsing the version and just looking at the latest release in terms of date. I recommend parsing the version and comparing them numerically to decide whether a version is newer or not.

@SebastianStehle
Copy link

Have you seen this one: #20

@saadmk11
Copy link
Owner

Hi @starikcetin, Thanks for creating the issue, The fix (#19) is already merged to the main branch. Please try it out using saadmk11/github-actions-version-updater@main and let me know if it solves the issue you are facing.

I am planning to do a release tomorrow or on this weekend :)

@saadmk11
Copy link
Owner

Closing the issue as the changes has been released. https://github.com/saadmk11/github-actions-version-updater/releases/tag/v0.7.0

Feel free to Re-Open if the issue is not fixed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants