Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrades are being proposed #20

Closed
FriedrichFroebel opened this issue Oct 16, 2022 · 4 comments · Fixed by #19
Closed

Downgrades are being proposed #20

FriedrichFroebel opened this issue Oct 16, 2022 · 4 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@FriedrichFroebel
Copy link

There seems to be something off with resolving the actual version changes:

Found new version for "actions/checkout"
  Updating "actions/checkout@v3" with "actions/[email protected]"
  Found new version for "saadmk11/github-actions-version-updater"
  Updating "saadmk11/github-actions-version-updater@main" with "saadmk11/[email protected]"
  Found new version for "actions/setup-python"
  Updating "actions/setup-python@v4" with "actions/[email protected]"

The specific issues I see here:

  • v2.5.0 is considered more recent than version v3 for actions/checkout.
  • v0.5.6 is considered more recent than main, although main references the latest unreleased code from the default branch.
  • v4.3.0 is being proposed for the short syntax v4, although I would assume that v4 will always use the latest release of the v4 major version (currently being v4.3.0 for actions/setup-python). I am not sure about this though, as I could not find any information on which version is being picked by GitHub Actions in this case.
@saadmk11
Copy link
Owner

Hi @FriedrichFroebel, Thanks for reporting this issue.

  • v2.5.0 is considered more recent than version v3 for actions/checkout.

This is a known problem. This is happening because this action uses GitHub's Latest Release API which returns the Latest Release Published by the repository, which sometimes may not be the latest version available for the action (e.g: if the repository is maintaining multiple versions at the same time v2.x, v3.x and a new version of v2.x is released)

  • v0.5.6 is considered more recent than main, although main references the latest unreleased code from the default branch.

The Action Currently Supports Tags Only (will support commit SHA (from default branch or latest release Tag) in the near future. #19). There is no plan for suggesting branches.

  • v4.3.0 is being proposed for the short syntax v4, although I would assume that v4 will always use the latest release of the v4 major version (currently being v4.3.0 for actions/setup-python). I am not sure about this though, as I could not find any information on which version is being picked by GitHub Actions in this case.

This behavior is intentional. This Action will not suggest moving versions rather it will suggest specific versions.

@saadmk11 saadmk11 added the bug Something isn't working label Oct 16, 2022
@FriedrichFroebel
Copy link
Author

Thanks for the explanations. In my opinion, these limits should be mentioned somewhere in the docs as well, as otherwise one will just stumble upon them when actually trying to use them.

@saadmk11
Copy link
Owner

  • v2.5.0 is considered more recent than version v3 for actions/checkout.

This is a known problem. This is happening because this action uses GitHub's Latest Release API which returns the Latest Release Published by the repository, which sometimes may not be the latest version available for the action (e.g: if the repository is maintaining multiple versions at the same time v2.x, v3.x and a new version of v2.x is released)

Fixed on #19

@SebastianStehle
Copy link

Awesome, thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants