Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): add message deletion #42

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

Silthus
Copy link
Collaborator

@Silthus Silthus commented Nov 17, 2021

Closes #12

@Silthus Silthus added the enhancement New feature or request label Nov 17, 2021
@Silthus Silthus self-assigned this Nov 17, 2021
@Silthus Silthus changed the title feat(api): add method to delete messages feat(chat): add message deletion Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #42 (bbca5a5) into beta (aaa1b10) will increase coverage by 0.39%.
The diff coverage is 95.91%.

Impacted file tree graph

@@             Coverage Diff              @@
##               beta      #42      +/-   ##
============================================
+ Coverage     81.32%   81.71%   +0.39%     
- Complexity      460      483      +23     
============================================
  Files            55       56       +1     
  Lines          1499     1537      +38     
  Branches        118      119       +1     
============================================
+ Hits           1219     1256      +37     
- Misses          191      193       +2     
+ Partials         89       88       -1     
Impacted Files Coverage Δ
src/main/java/net/silthus/chat/ChatTarget.java 100.00% <ø> (ø)
src/main/java/net/silthus/chat/Constants.java 64.28% <ø> (ø)
.../main/java/net/silthus/chat/scopes/LocalScope.java 100.00% <ø> (ø)
...main/java/net/silthus/chat/scopes/ServerScope.java 100.00% <ø> (ø)
.../main/java/net/silthus/chat/scopes/WorldScope.java 100.00% <ø> (ø)
src/main/java/net/silthus/chat/SChat.java 61.14% <50.00%> (ø)
src/main/java/net/silthus/chat/Scopes.java 85.00% <75.00%> (-1.49%) ⬇️
src/main/java/net/silthus/chat/Message.java 78.20% <100.00%> (+0.57%) ⬆️
src/main/java/net/silthus/chat/Scope.java 100.00% <100.00%> (ø)
...lthus/chat/conversations/AbstractConversation.java 88.46% <100.00%> (+2.09%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa1b10...bbca5a5. Read the comment docs.

@Silthus Silthus marked this pull request as ready for review November 17, 2021 19:19
@Silthus Silthus merged commit a7b20bc into beta Nov 17, 2021
@Silthus Silthus deleted the feature/12-message-deletion branch November 17, 2021 19:29
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-SNAPSHOT.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-SNAPSHOT.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

2 similar comments
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant