progress bar improvements #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, @s9roll7 just checking in, any feedback on this update to progress bars? |
s9roll7
reviewed
Nov 2, 2023
| @@ -1148,9 +1146,6 @@ def preview_callback(i: int, video: torch.Tensor, save_fn: Callable[[torch.Tenso | |||
|
|
|||
| seed_everything(seed) | |||
|
|
|||
| logger.info(f"{len( region_condi_list )=}") | |||
| logger.info(f"{len( region_list )=}") | |||
|
|
|||
| pipeline_output = pipeline( | |||
There was a problem hiding this comment.
Basically, don't delete the logs left in the code.
Most of the time, they are still being debugged or are left to investigate behavior that could be improved.
s9roll7
reviewed
Nov 2, 2023
| @@ -2886,6 +2898,7 @@ def sample_to_device( sample ): | |||
| tmp_latent = None | |||
|
|
|||
| stopwatch_stop("LOOP end") | |||
| progress_bar.update() | |||
|
|
|||
There was a problem hiding this comment.
I do not want to change the units of progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @s9roll7, another one with some improvements to progress bars. Addresses the main comment in #121.
Here's what it looks like (running with a preview output every 5 steps):
new.progress.bar2.mp4
@SoftologyPro would this address your issue?