Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use msgspec serializer #20

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

s7clarke10
Copy link
Owner

Problem

The underlying singer framework has not been patched for a long time and their a faster json serializes which can improve the performance of this tap.

Proposed changes

Pulling in a new fully patched version of pipelinewise-singer-python.

Types of changes

  • Updating to a patched version of pipelinewise-singer-python using msgspec instead of orjson for serialization.

  • Speeding up tap-oracle via the use of new pipelinewise-singer-python library.

  • deprecating support for Python 3.7, and adding support for Python 3.11 and 3.12 via pipelinewise-singer-python.

  • Testing of this change has been documented here : Feature/setup to pyproject realit-singer-python#24

  • Bugfix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@s7clarke10 s7clarke10 merged commit 10a830b into master Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant