Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cran Error in Suggests related to "lfe" #12

Closed
s3alfisc opened this issue Jul 29, 2021 · 3 comments
Closed

Cran Error in Suggests related to "lfe" #12

s3alfisc opened this issue Jul 29, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@s3alfisc
Copy link
Owner

s3alfisc commented Jul 29, 2021

"Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_fwildclusterboot.html.

Please correct before 2021-08-08 to safely retain your package on CRAN.

Packages in Suggests should be used conditionally: see 'Writing R Extensions'.
This needs to be corrected even if the missing package(s) become available."
From "writing R extensions":

"1.1.3.1 Suggested packages

Note that someone wanting to run the examples/tests/vignettes may not have a suggested package available (and it may not even be possible to install it for that platform). The recommendation used to be to make their use conditional via if(require("pkgname")): this is OK if that conditioning is done in examples/tests/vignettes, although using if(requireNamespace("pkgname")) is preferred, if possible. "

@s3alfisc s3alfisc added the bug Something isn't working label Jul 29, 2021
@s3alfisc
Copy link
Owner Author

s3alfisc commented Jul 29, 2021

Added if(requireNamespace("pkgname")) statements for suggested packages in the vignettes, examples and tests.

Note that unit tests will now only execute on CRAN if both fixest and lfe can be installed on the specific OS.

Currently, package installation fails on ubuntu-20.04 (devel) because the installation of the suggested "lfe" package fails (based on commit c84fffe).

See also https://cran.r-project.org/web/checks/check_results_lfe.html.

Probably related to this bug in "lfe": sgaure/lfe#49.

@MatthieuStigler
Copy link

lfe 2.8-7 was just accepted on CRAN, this should fix the issue!?

@s3alfisc
Copy link
Owner Author

s3alfisc commented Aug 2, 2021

Hi Mathieu, thanks for letting me know! This indeed fixes this issue :)
All bugs mentioned above are now adressed with version 0.3.6 and commit bf3d289 & fwildclusterboot 0.3.6 is on CRAN!

@s3alfisc s3alfisc closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants