Shield hit punchangle change logic grouped #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0werD
reviewed
Aug 16, 2024
Comment on lines
+1493
to
+1495
| if (Q_fabs(pev->punchangle.x) < 4.0) | ||
| { | ||
| pev->punchangle.x = clamp(flDamage * RANDOM_FLOAT(-0.15, 0.15), -4.0f, 4.0f); |
There was a problem hiding this comment.
In original code another logic
fl0werD
reviewed
Aug 16, 2024
| #endif | ||
|
|
||
| #ifdef REGAMEDLL_FIXES | ||
| if (Q_fabs(pev->punchangle.z) < 5.0) |
There was a problem hiding this comment.
I think it's useless check because clamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes fixes from #919
Logic when player gets shield hit is now grouped with a couple fixes and angle clamping.
It also fixes the angle zeroing when shield hitted from shotguns, which are not handled in FireBullets3 but TraceAttack instead.