Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure m_pDriver assignation on func_vehicle only #853

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

dystopm
Copy link
Contributor

@dystopm dystopm commented Jul 22, 2023

m_pDriver is a member present only on CFuncVehicle class, in CBasePlayer workflow there's a train quitting logic where game is setting m_pDriver to NULL on both entities func_vehicle and func_tracktrain, which shares FCAP_DIRECTIONAL_USE ObjectCaps flag but the last one doesn't have m_pDriver member (including the implicit cast to CFuncVehicle on code)

Workaround (and ToDo): Train quitting logic is quite similar, should that be grouped in a single function?

@wopox1337
Copy link
Collaborator

Train quitting logic is quite similar, should that be grouped in a single function?

@dystopm sure

@s1lentq s1lentq merged commit 2e6e779 into s1lentq:master Sep 5, 2023
4 checks passed
@dystopm dystopm deleted the vehicle-member-fix branch October 11, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants