Fix: Glock18 and Famas undesired ammo decreasing on burst mode #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1lentq @wopox1337 it's worth it? |
wopox1337
reviewed
Jul 10, 2023
| @@ -761,16 +761,19 @@ void CBasePlayerWeapon::FireRemaining(int &shotsFired, float &shootTime, BOOL bI | |||
| if (bIsGlock) | |||
| { | |||
| vecDir = m_pPlayer->FireBullets3(vecSrc, gpGlobals->v_forward, 0.05, 8192, 1, BULLET_PLAYER_9MM, 18, 0.9, m_pPlayer->pev, true, m_pPlayer->random_seed); | |||
| #ifndef REGAMEDLL_FIXES | |||
| --m_pPlayer->ammo_9mm; | |||
There was a problem hiding this comment.
I can't understand the original logic behind valve's original GameDLL. Why does it need to reduce ammo from the holster every time a shot is fired? It's weird.
wopox1337
approved these changes
Jul 10, 2023
wopox1337
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the next scenario:
You need to call TabulateAmmo to enable reload again (shoot in single mode).
There is no reason to decrease bpammo on clip decreasing action anyways.
(and there is no reason to use ammo_ members from CBaseEntity)