Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CVar: mp_hostages_rescued_ratio #786

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

fl0werD
Copy link
Contributor

@fl0werD fl0werD commented Nov 21, 2022

https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/dlls/multiplay_gamerules.cpp#L1471
This business logic does not work correctly because the code below does not consider by 50%.
https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/dlls/multiplay_gamerules.cpp#L1482

Adding cvar for ratio and and default value for compatibility.

@wopox1337 wopox1337 changed the title Add mp_hostages_rescued_ratio cvar New CVar: mp_hostages_rescued_ratio Nov 24, 2022
@wopox1337
Copy link
Collaborator

:D
The standard conditions of the game are quite strange

https://youtu.be/lvXW_PIqYN0

@wopox1337 wopox1337 merged commit 84f1f5e into s1lentq:master Nov 24, 2022
@RauliTop
Copy link
Contributor

@fl0werD @wopox1337
Also, we must disable bHostageAlive var with #ifndef REGAMEDLL_ADD

@fl0werD
Copy link
Contributor Author

fl0werD commented Nov 29, 2022

@RauliTop it able to be more ifdef macros, but it unreadable fine. We can also wrap more code into macros, but now it's minimal edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants