Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'fast fire glitch' at AUG/SG552 #734

Merged
merged 5 commits into from
Dec 17, 2022
Merged

Conversation

RauliTop
Copy link
Contributor

@RauliTop RauliTop commented Feb 21, 2022

Bug is caused because of not checking weapon's FOV in some conditions.

close #703

comment from @wopox1337

If we keep changing the shared code of weapons for the server side, at some point in time we will get more and more out of sync with the client side (prediction) and this will adversely affect the overall experience of the game for the average player.

I propose to leave this behavior "as is".

Well, if you don't want to merge it. Let be open to documentation.

Bug is caused because of not checking his fov in some conditions.
@Vaqtincha
Copy link
Contributor

KickBack should also be smaller when the player aimed (fov 55)

@RauliTop
Copy link
Contributor Author

KickBack should also be smaller when the player aimed (fov 55)

Why? kickback isn't based on FOV

@Vaqtincha

This comment was marked as resolved.

@wopox1337 wopox1337 changed the title Fix 'fast fire glitch' at AUG/SG552 Fix: 'fast fire glitch' at AUG/SG552 Dec 17, 2022
@wopox1337 wopox1337 self-requested a review December 17, 2022 18:05
Copy link
Collaborator

@wopox1337 wopox1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, there are problems with wpn_shared behavior prediction discrepancy, but they only affect clients whose pings are above 70. In general, it's not critical, I think it's possible to make this fix in ReGameDLL.

Video: https://youtu.be/-SLAXhhGwu0
name

@wopox1337
Copy link
Collaborator

btw CS:GO code:

void CWeaponSG552::PrimaryAttack()
{
	CCSPlayer *pPlayer = GetPlayerOwner();
	if ( !pPlayer )
		return;

	bool bZoomed = pPlayer->GetFOV() < pPlayer->GetDefaultFOV();

	float flCycleTime = GetCycleTime();

	if ( bZoomed )
		flCycleTime = 0.135f;

	CSBaseGunFire( flCycleTime, m_weaponMode );
}

@wopox1337 wopox1337 merged commit 7caf748 into s1lentq:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fast fire glitch
3 participants