Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CBasePlayer::Observer_SetMode hook #663

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Implement CBasePlayer::Observer_SetMode hook #663

merged 1 commit into from
Aug 31, 2021

Conversation

Lopol2010
Copy link
Contributor

@Lopol2010 Lopol2010 commented Aug 16, 2021 •
edited
Loading

related issue rehlds/reapi#207

@StevenKal
Copy link
Contributor

Value of "GetForceCamera" hook could possibly overwrite your custom mode, and if set to "CAMERA_MODE_SPEC_ONLY_FIRST_PERSON" (2) eye camera will be set internally.

@Lopol2010
Copy link
Contributor Author

Lopol2010 commented Aug 17, 2021 •
edited
Loading

Hi it seems in my server spectator restrictions work fine. Also i think if you have problems then you can set GetForceCamera return to any values? Sorry if my anwser is irrelevant, i dont understand much.

@StevenKal
Copy link
Contributor

StevenKal commented Aug 24, 2021 •
edited by wopox1337
Loading

This can be pushed too (with adjustements regarding other hooks of @fl0werD, or keep v5.21 and merge all [4 hooks] at once).

@Lopol2010

This comment has been minimized.

Sign in to view
@hajimura

This comment has been minimized.

Sign in to view
@StevenKal
Copy link
Contributor

StevenKal commented Aug 30, 2021 •
edited
Loading

I was just refering to the "5.21" version upgrade, but I think while the maintainer/collaborators do not push a release in the "Releases" section but keep adding/merging some new API functions, your hook could keep "5.21" as version and be added after fl0werD's hooks recently added (other API functions could even be added at same time and keep same version), no need to push to 5.22.
But you probably have to edit "the conflicts files" listed below.

@wopox1337 wopox1337 self-requested a review August 31, 2021 11:44
@wopox1337 wopox1337 self-assigned this Aug 31, 2021
@wopox1337 wopox1337 assigned Lopol2010 and unassigned wopox1337 Aug 31, 2021
@wopox1337 wopox1337 changed the title Implement RG_CBasePlayer_Observer_SetMode hook Implement CBasePlaye::Observer_SetMode hook Aug 31, 2021
@wopox1337 wopox1337 changed the title Implement CBasePlaye::Observer_SetMode hook Implement CBasePlayer::Observer_SetMode hook Aug 31, 2021
@wopox1337 wopox1337 merged commit f1b253e into s1lentq:master Aug 31, 2021
@wopox1337 wopox1337 mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopox1337 wopox1337 wopox1337 approved these changes

Assignees

@Lopol2010 Lopol2010

Labels
Priority: Low Status: Completed Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lopol2010 @StevenKal @hajimura @wopox1337