Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly format json for firehose #40

Closed
wants to merge 1 commit into from
Closed

Properly format json for firehose #40

wants to merge 1 commit into from

Conversation

Bashton-MattBuckland
Copy link

This was already done for streams in a086eea

@Bashton-MattBuckland
Properly format json for firehose
6320366 
This was already done for streams in a086eea
@Bashton-MattBuckland Bashton-MattBuckland mentioned this pull request Jun 21, 2018
Closed
@mumoshu
Copy link
Collaborator

mumoshu commented Jun 25, 2018

@Bashton-MattBuckland Hey. Thank you so much for the PR!

The build seems to be failing due to missing trailing newlines in the expected values.
Could you update these test go sources?

--- FAIL: TestMapEvent (0.00s)
	client_test.go:21: Unexpected data: boom
=== RUN   TestMapEvents
--- FAIL: TestMapEvents (0.00s)
	client_test.go:35: Unexpected data boom

@raymondbutcher
Copy link
Contributor

This commit is included in #44 so this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bashton-MattBuckland @mumoshu @raymondbutcher