Migrate to dep #16
Merged
Migrate to dep #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
dep
branch
3 times, most recently
from
8c3998b to
8a6b6ba
Compare
Ran `dep init` and then `dep ensure`. I had to remove elastic/beats from `Gopkg.toml` and re-run `dep ensure` to fix the strage error `target/filebeat-master-go1.10- flag redefined: strict.perms` in travis builds. Uses the latest stable release of `dep`: ``` $ dep version dep: version : v0.4.1 build date : 2018-01-27 git hash : 37d9ea0 go version : go1.9.3 go compiler : gc platform : darwin/amd64 ``` Resolves s12v#9
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 24.74% 24.74%
=======================================
Files 3 3
Lines 97 97
=======================================
Hits 24 24
Misses 68 68
Partials 5 5Continue to review full report at Codecov.
|
|
Finally the travis build is passing. I have already verified it to work on my dockerized filebeat+awsbeat. Will submit the Dockerfile later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
dep initand thendep ensure. I had to remove elastic/beats fromGopkg.tomland re-rundep ensureto fix the strage errortarget/filebeat-master-go1.10- flag redefined: strict.permsin travis builds.Uses the latest stable release of
dep:Resolves #9