fix: Correct records sent to Kinesis Data Streams #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Streams This should be enhanced to cover firehose and other beats. This is just a starting point :)
Fixes s12v#11 `glide up` wasnt necessarily but anyway I verified this to work with the latest version of aws-sdk-go
mumoshu
force-pushed
the
fix-stream-record-corruption
branch
from
e48c1c3 to
cd1aafe
Compare
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
+ Coverage 21.73% 24.74% +3%
=======================================
Files 3 3
Lines 92 97 +5
=======================================
+ Hits 20 24 +4
- Misses 67 68 +1
Partials 5 5
Continue to review full report at Codecov.
|
|
@mumoshu can you add the fix to firehose as well? |
s12v
reviewed
May 23, 2018
| // See https://github.com/elastic/beats/blob/5a6630a8bc9b9caf312978f57d1d9193bdab1ac7/libbeat/outputs/kafka/client.go#L163-L164 | ||
| // You need to copy the byte data like this. Otherwise you see strange issues like all the records sent in a same batch has the same Data. | ||
| buf = make([]byte, len(serializedEvent)) | ||
| copy(buf, serializedEvent) |
s12v
approved these changes
May 23, 2018
Merged
mumoshu
added a commit
that referenced
this pull request
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glide upwasnt necessarily but anyway I verified this to work with the latest version of aws-sdk-goFixes #11
Depends on #12. Plese see the last commit to review the change made in this PR.