Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittests and CI #7

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Add unittests and CI #7

merged 2 commits into from
Aug 30, 2024

Conversation

moritzsommer
Copy link
Collaborator

@moritzsommer moritzsommer commented Aug 29, 2024 •
edited by s-heppner
Loading

Previously, we did not have any testing.
This introduces unittests and configures them
to run as CI workflow.

Fix #6

@moritzsommer moritzsommer linked an issue Aug 29, 2024 that may be closed by this pull request
Missing test cases #6
Closed
@moritzsommer moritzsommer requested a review from s-heppner August 29, 2024 18:34
s-heppner
s-heppner approved these changes Aug 30, 2024
View reviewed changes
Copy link
Owner

@s-heppner s-heppner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@s-heppner s-heppner changed the title 6 missing test cases Add unittests and CI Aug 30, 2024
@s-heppner s-heppner merged commit 24d3a20 into master Aug 30, 2024
2 checks passed
@s-heppner s-heppner deleted the 6-missing-test-cases branch August 30, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-heppner s-heppner s-heppner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing test cases
2 participants
@moritzsommer @s-heppner