Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compile-time error messages in ascent_macro #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve compile-time error messages in ascent_macro #51

wants to merge 1 commit into from

Conversation

regexident
Copy link
Contributor

This PR …

  1. adds backticks around identifiers in error diagnostics, making it easier to distinguish between prose and code
  2. improves consistency by ensuring uniform capitalization (the norm in Rust is for errors to begin lowercased)
  3. improves the "wrong arity" error message (by mentioning not only the expected, but also the actual arity in it)

@regexident regexident mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@regexident